Skip to content

Simplify and clean up Sentry::RequestInterface's tests#1660

Merged
st0012 merged 1 commit intomasterfrom
refactor-request-interface-specs
Jan 2, 2022
Merged

Simplify and clean up Sentry::RequestInterface's tests#1660
st0012 merged 1 commit intomasterfrom
refactor-request-interface-specs

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Jan 2, 2022

No description provided.

@st0012 st0012 added this to the 4.9.0 milestone Jan 2, 2022
@st0012 st0012 self-assigned this Jan 2, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 2, 2022

Codecov Report

Merging #1660 (11207ac) into master (d9d6af4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1660      +/-   ##
==========================================
- Coverage   98.51%   98.49%   -0.02%     
==========================================
  Files         136      136              
  Lines        7672     7651      -21     
==========================================
- Hits         7558     7536      -22     
- Misses        114      115       +1     
Impacted Files Coverage Δ
...y/spec/sentry/interfaces/request_interface_spec.rb 99.01% <100.00%> (-0.17%) ⬇️
sentry-ruby/lib/sentry/breadcrumb.rb 95.65% <0.00%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9d6af4...11207ac. Read the comment docs.

@st0012 st0012 merged commit d5d045b into master Jan 2, 2022
@st0012 st0012 deleted the refactor-request-interface-specs branch January 2, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants