Fixes report_after_job_retries for retry: 0#1557
Merged
st0012 merged 3 commits intogetsentry:masterfrom Sep 1, 2021
Merged
Conversation
cc94cae to
3e04213
Compare
3e04213 to
dceb18d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1557 +/- ##
==========================================
+ Coverage 97.92% 98.29% +0.37%
==========================================
Files 222 127 -95
Lines 10867 7033 -3834
==========================================
- Hits 10641 6913 -3728
+ Misses 226 120 -106 Continue to review full report at Codecov.
|
Contributor
|
@TAGraves thanks for reporting the issue and making the fix! |
Contributor
Author
|
@st0012 done, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes #1556 by checking to see if retry_option is positive.
The issue is that
retry_countis nil whenretry: 0is set. Since retries will only occur ifretry_optionis positive we can skip this altogether in the case where it is not positive.