Skip to content

Limit breadcrumb's message length#1465

Merged
st0012 merged 2 commits intomasterfrom
fix-#1422
Jun 4, 2021
Merged

Limit breadcrumb's message length#1465
st0012 merged 2 commits intomasterfrom
fix-#1422

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Jun 4, 2021

Sentry::Event's message has a 8096 size limit, which should also be applied to breadcrumb's message to prevent useless and even harmful data.

This should partially fix #1422

@st0012 st0012 added this to the 4.5.1 milestone Jun 4, 2021
@st0012 st0012 self-assigned this Jun 4, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 4, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.84%. Comparing base (a72ddc7) to head (41dce08).
⚠️ Report is 817 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1465      +/-   ##
==========================================
+ Coverage   98.24%   98.84%   +0.59%     
==========================================
  Files         214      119      -95     
  Lines       10142     6319    -3823     
==========================================
- Hits         9964     6246    -3718     
+ Misses        178       73     -105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@st0012 st0012 merged commit 9c3d474 into master Jun 4, 2021
@st0012 st0012 deleted the fix-#1422 branch June 4, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mysql2::Error: MySQL client is not connected

2 participants