Skip to content

fix: Update protocol version to 7#1434

Merged
st0012 merged 2 commits intomasterfrom
rhcarvalho/proto-v7
May 7, 2021
Merged

fix: Update protocol version to 7#1434
st0012 merged 2 commits intomasterfrom
rhcarvalho/proto-v7

Conversation

@rhcarvalho
Copy link
Copy Markdown
Contributor

@rhcarvalho rhcarvalho commented May 6, 2021

Modern SDKs use protocol version 7.

The version triggers different code paths during ingestion, and so the modern Ruby SDK should also use v7.

See https://develop.sentry.dev/sdk/overview/#authentication.

Fixes #867

@rhcarvalho rhcarvalho requested a review from st0012 May 6, 2021 15:49
@st0012 st0012 added this to the sentry-ruby-4.4.2 milestone May 6, 2021
@st0012
Copy link
Copy Markdown
Contributor

st0012 commented May 6, 2021

@rhcarvalho thanks for catching this. can you also add a changelog entry for it?

@st0012
Copy link
Copy Markdown
Contributor

st0012 commented May 6, 2021

@rhcarvalho looks like the tests are failing. I'll take care of this if you don't mind?

@rhcarvalho
Copy link
Copy Markdown
Contributor Author

I'll take care of this if you don't mind?

Yes, please do take over, I'd appreciate your help with tests+changelog 👍

rhcarvalho and others added 2 commits May 7, 2021 17:17
Modern SDKs use protocol version 7.

The version triggers different code paths during ingestion, and so the modern Ruby SDK should also use v7.
@st0012 st0012 force-pushed the rhcarvalho/proto-v7 branch from 98dd4b9 to 54bdba2 Compare May 7, 2021 09:17
@st0012 st0012 merged commit 3481bf2 into master May 7, 2021
@st0012 st0012 deleted the rhcarvalho/proto-v7 branch May 7, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change protocol version to 7

2 participants