Skip to content

Record breadcrumb for Net::HTTP requests#1394

Merged
st0012 merged 6 commits intomasterfrom
implement-#778
Apr 12, 2021
Merged

Record breadcrumb for Net::HTTP requests#1394
st0012 merged 6 commits intomasterfrom
implement-#778

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Apr 11, 2021

Usage

Add this to your config

config.breadcrumbs_logger = [:http_logger]

And then you'll see net.http breadcrumbs appear whenever you make a request with the Net::HTTP library.

net http breadcrumb

Closes #778

@st0012 st0012 added this to the 4.4.0 milestone Apr 11, 2021
@st0012 st0012 self-assigned this Apr 11, 2021
st0012 added 4 commits April 11, 2021 17:11
This check makes breadcrumbs loggers not easily extensible.
Usage:

```ruby
config.breadcrumbs_logger << :http_logger
```

Then the SDK would start adding breadcrumbs for every outgoing http
request that's performed with the Net::HTTP library.
@st0012 st0012 changed the title Record breadcrumb for outgoing requests Record breadcrumb for Net::HTTP requests Apr 11, 2021
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 11, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.80%. Comparing base (5486ef7) to head (68a44f5).
⚠️ Report is 968 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1394      +/-   ##
==========================================
+ Coverage   98.19%   98.80%   +0.60%     
==========================================
  Files         214      119      -95     
  Lines        9758     6001    -3757     
==========================================
- Hits         9582     5929    -3653     
+ Misses        176       72     -104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@st0012 st0012 merged commit 4264822 into master Apr 12, 2021
@st0012 st0012 deleted the implement-#778 branch April 12, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Track network requests as breadcrumbs

2 participants