Fix handle the case where the logger messages is not of String type#1341
Merged
st0012 merged 3 commits intogetsentry:masterfrom Mar 17, 2021
Merged
Fix handle the case where the logger messages is not of String type#1341st0012 merged 3 commits intogetsentry:masterfrom
st0012 merged 3 commits intogetsentry:masterfrom
Conversation
st0012
approved these changes
Mar 17, 2021
Contributor
|
@fumitti thanks for catching this and making this PR 😄 |
|
@fumitti thanks for the fix. I've notice the same bug and temporary fix is replacing sentry_logger with active_support_logger |
st0012
pushed a commit
that referenced
this pull request
Mar 19, 2021
…1341) * Fix handle the case where the message is not of String type * add logger test * Update CHANGELOG.md
st0012
pushed a commit
that referenced
this pull request
Mar 20, 2021
…1341) * Fix handle the case where the message is not of String type * add logger test * Update CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Passing something other (like Integer) than a String type to the logger will fail because there is no "empty?" method.
Fixed based on old raven source
https://github.com/getsentry/sentry-ruby/blob/master/sentry-raven/lib/raven/breadcrumbs/sentry_logger.rb#L22