Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1177 +/- ##
==========================================
+ Coverage 97.93% 98.52% +0.59%
==========================================
Files 190 97 -93
Lines 7973 4211 -3762
==========================================
- Hits 7808 4149 -3659
+ Misses 165 62 -103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
agrobbin
added a commit
to agrobbin/sentry-ruby
that referenced
this pull request
Jan 26, 2021
This was replaced in getsentry#1177, but the middleware wasn't actually removed.
st0012
pushed a commit
that referenced
this pull request
Jan 29, 2021
…1238) * remove now-unused Sidekiq CleanupMiddleware This was replaced in #1177, but the middleware wasn't actually removed. * extract wrapped Sidekiq job class names in both Sidekiq integrations The Active Job `wrapped` job class name logic was only happening in the lower-level `ErrorHandler`, and was actually being ignored since `transaction_name` was already set via `SentryContextMiddleware`. Now, the logic to properly extract the `transaction_name` has been refactored into `ContextFilter`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the goals of the new SDK is to provide clear documentation + convenient helpers to let communities develop their own extensions around the SDK. And the
Integrablemodule added in this PR is our first step to make that happen.The integrable module provides a simple DSL for registering the extension. Let me use
sentry-railsas an example:Once the extension is registered, 2 things will happen:
Sentry::Rails.capture_exceptionandSentry::Rails.capture_messagemethods.{name: "sentry.ruby.rails", version: Sentry::Rails::VERSION}in this case.Then in the extension gem, all the reporting should be done via the newly generated helpers. This is because:
{ integration: "integration_name" }to the event hints. So the users can later identify the source of each event.This change also fixes the current SDK-info overridden issue, which is when using
sentry-railsandsentry-sidekiqare used together, the SDK info will be decided by the order of the gem definitions in theGemfileinstead of where is the event being created.But besides the above bug fix, this change shouldn't affect normal users.