Skip to content

Move sentry-raven into its own folder#1125

Merged
st0012 merged 9 commits intomasterfrom
move-sentry-raven
Dec 10, 2020
Merged

Move sentry-raven into its own folder#1125
st0012 merged 9 commits intomasterfrom
move-sentry-raven

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Dec 6, 2020

Since sentry-raven is the deprecated SDK now, it makes more sense to move it into its own folder, just like other gems.

Todo:

  • code & specs
  • workflow config
  • release config
  • readme

@st0012 st0012 added this to the 4.0.0 milestone Dec 6, 2020
@st0012 st0012 self-assigned this Dec 6, 2020
@st0012 st0012 force-pushed the move-sentry-raven branch from 9093727 to aa63076 Compare December 6, 2020 09:14
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 6, 2020

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.55%. Comparing base (57c318a) to head (4af5703).
⚠️ Report is 1218 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1125      +/-   ##
==========================================
- Coverage   98.22%   97.55%   -0.68%     
==========================================
  Files         152      123      -29     
  Lines        6466     4492    -1974     
==========================================
- Hits         6351     4382    -1969     
+ Misses        115      110       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@st0012 st0012 force-pushed the move-sentry-raven branch 2 times, most recently from 9c98279 to de2b478 Compare December 10, 2020 07:44
@st0012 st0012 merged commit 82e1ffe into master Dec 10, 2020
@st0012 st0012 deleted the move-sentry-raven branch December 10, 2020 09:09
jeffwidman added a commit to dependabot/dependabot-core that referenced this pull request Jul 16, 2023
The Sentry team deprecated `sentry-raven` nearly three years ago:
* getsentry/sentry-ruby#1125

So this migrates to their replacement `sentry-ruby` gem.

Beyond the namespace changes, the major logical changes are:
1. Events now default to sending asynchronously using a thread pool
   whereas raven used to send them synchronously.
2. The `raven_context` attached to exceptions is no longer automatically
   picked up. It must be explicitly wired in.
3. Processor classes were removed. This didn't matter much to us as we
   had only a single `ExceptionSanitizer`, which is easily wired into
   the `before_send()` interface.
4. The `config.logger` param was removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants