Add: Request ID to rack related events#1111
Closed
tvec wants to merge 2 commits intogetsentry:masterfrom
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1111 +/- ##
==========================================
+ Coverage 98.04% 98.05% +0.01%
==========================================
Files 144 147 +3
Lines 6101 6133 +32
==========================================
+ Hits 5982 6014 +32
Misses 119 119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- moved request id logic to the shared utils - add request_id tagging when encountering a Rack related Event
- moved request id logic to the shared utils - add request_id tagging when encountering a Rack related Event
487f9de to
c46ef35
Compare
st0012
suggested changes
Nov 26, 2020
Contributor
st0012
left a comment
There was a problem hiding this comment.
ah sorry, in order to make tracking/reverting the change easier (not likely though, just in case), can you split the changes into 2 PRs? one for each gem.
Contributor
Author
This was referenced Nov 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
request_idto shared utilsrequest_idtags (when present) to Rack eventSentry::Event&Raven::EventnamespacesWhy
Testing