Skip to content

Add request id to headers if exists#1033

Merged
st0012 merged 1 commit intogetsentry:v3-1-stablefrom
berniechiu:auto-add-request-id
Sep 20, 2020
Merged

Add request id to headers if exists#1033
st0012 merged 1 commit intogetsentry:v3-1-stablefrom
berniechiu:auto-add-request-id

Conversation

@berniechiu
Copy link
Copy Markdown
Contributor

@berniechiu berniechiu commented Sep 19, 2020 •
edited
Loading

Description

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 19, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (v3-1-stable@b66cc99). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             v3-1-stable    #1033   +/-   ##
==============================================
  Coverage               ?   98.15%           
==============================================
  Files                  ?       56           
  Lines                  ?     2443           
  Branches               ?        0           
==============================================
  Hits                   ?     2398           
  Misses                 ?       45           
  Partials               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b66cc99...e305965. Read the comment docs.

@st0012 st0012 changed the base branch from master to v3-1-stable September 19, 2020 12:47
@st0012 st0012 changed the base branch from v3-1-stable to master September 19, 2020 12:47
st0012
st0012 suggested changes Sep 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR 👍 just added some small suggestions
also, can you rebase this PR (or cherry-picking the commits) against v3-1-stable instead of master?
sorry I didn't make it clear but we currently only accept contributions to the 3.1.x versions before the v4 is finished. (I have updated the readme & PR template for this though)

@st0012 st0012 added this to the 3.1.1 milestone Sep 19, 2020
@berniechiu berniechiu changed the base branch from master to v3-1-stable September 20, 2020 00:54
@berniechiu
Copy link
Copy Markdown
Contributor Author

berniechiu commented Sep 20, 2020 •
edited
Loading

thanks for the PR 👍 just added some small suggestions
also, can you rebase this PR (or cherry-picking the commits) against v3-1-stable instead of master?
sorry I didn't make it clear but we currently only accept contributions to the 3.1.x versions before the v4 is finished. (I have updated the readme & PR template for this though)

No prob~~ done~

@st0012
Copy link
Copy Markdown
Contributor

st0012 commented Sep 20, 2020

@berniechiu thanks for the work 👍

@st0012 st0012 merged commit e05c8c5 into getsentry:v3-1-stable Sep 20, 2020
@tvec tvec mentioned this pull request Nov 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@st0012 st0012 st0012 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@berniechiu @codecov-commenter @st0012