Conversation
This will replace the way we activate our breadcrumbs loggers. Currently, we have `SentryLogger` and `ActiveSupportLogger` for logging breadcrumbs. And they need to be activated differently: ```ruby require "raven/breadcrumbs/sentry_logger" Raven.configuration.rails_activesupport_breadcrumbs = true ``` It's not a nice user interface, so this commit adds a new configuration options "breadcrumbs_logger" to solve this: ```ruby Raven.configuration.breadcrumbs_logger = :sentry_logger Raven.configuration.breadcrumbs_logger = :active_support_logger Raven.configuration.breadcrumbs_logger = [:sentry_logger, :active_support_logger] ```
Codecov Report
@@ Coverage Diff @@
## master #1016 +/- ##
=======================================
Coverage 97.85% 97.85%
=======================================
Files 54 53 -1
Lines 2377 2379 +2
=======================================
+ Hits 2326 2328 +2
Misses 51 51
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will replace the way we activate our breadcrumbs loggers.
Currently, we have
SentryLoggerandActiveSupportLoggerforlogging breadcrumbs. And they need to be activated differently:
It's not a nice user interface, so this PR adds a new configuration
option
breadcrumbs_loggerto improve this:However, the old activation ways will still be supported until version 4.0 with deprecation warnings.
Closes #665