Skip to content

Several processors broken when using async #622

@garjust

Description

@garjust

After this change: getsentry/raven-ruby@a786def the async handler is passed a hash with string keys whereas send_event and the processors included in raven expect symbol keys in the event hash.

It is not clear that the client is expected to transform the event hash back into a hash with symbol keys before passing to send_event.

Just enumerating some ideas:

  • send_event should turn all the keys into symbols
  • When working with an event hash throughout the gem string keys should be used
  • Revert this change and have clients JSONify the event if needed in their async proc
  • Some sort of configuration option to pass the actual event object to async

Metadata

Metadata

Assignees

No one assigned

    Labels

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions