Skip to content

Expose :value in SingleExceptionInterface #2071

@jeffwidman

Description

@jeffwidman

👋 Hi from the :dependabot: team.

I'm attempting to migrate from sentry-raven to sentry-ruby:

With Raven we performed some basic client-side sanitization of the exception message:
https://github.com/dependabot/dependabot-core/blob/65f1c2d24e88ac57ed8df980871446deb5ea2d94/updater/lib/dependabot/sentry.rb#L5-L21

The unit tests illustrate how it works:
https://github.com/dependabot/dependabot-core/blob/65f1c2d24e88ac57ed8df980871446deb5ea2d94/updater/spec/dependabot/sentry_spec.rb#L24-L91

Migrating this from Raven to sentry-ruby's before_send is straightforward. However, it looks like sentry-ruby doesn't expose :value on SingleExceptionInterface:

attr_reader :type, :value, :module, :thread_id, :stacktrace

I see a recent change was made to expose :values on ExceptionInterface:

So I'm guessing there's no technical reason this can't be made publicly writable? Just no one has raised a feature request for it yet?

Metadata

Metadata

Assignees

No one assigned
    No fields configured for issues without a type.

    Projects

    Status

    Waiting for: Product Owner

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions