Skip to content

Expose :values in ExceptionInterface#1843

Merged
sl0thentr0py merged 1 commit intomasterfrom
neel/expose-values-exception
Jul 12, 2022
Merged

Expose :values in ExceptionInterface#1843
sl0thentr0py merged 1 commit intomasterfrom
neel/expose-values-exception

Conversation

@sl0thentr0py
Copy link
Copy Markdown
Member

useful for some before_send cases

fixes #1841

useful for some before_send cases
@sl0thentr0py sl0thentr0py requested a review from st0012 July 12, 2022 12:20
@sl0thentr0py sl0thentr0py merged commit b4f39d4 into master Jul 12, 2022
@sl0thentr0py sl0thentr0py deleted the neel/expose-values-exception branch July 12, 2022 13:07
@st0012
Copy link
Copy Markdown
Contributor

st0012 commented Jul 12, 2022

Since the purpose is to let users use it in before_send, maybe adding a changelog entry will be more helpful?

@st0012 st0012 added this to the 5.4.0 milestone Jul 12, 2022
@sl0thentr0py
Copy link
Copy Markdown
Member Author

Ah sorry, always forget that..
Will add an entry in one of the other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose values in ExceptionInterface

3 participants