Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

feat: Change VISIBILITY_CHANGE_TIMEOUT to match SESSION_IDLE_DURATION#98

Merged
billyvg merged 1 commit intomainfrom
feat/change-visibility-change-timeout-match-session-idle
Jun 29, 2022
Merged

feat: Change VISIBILITY_CHANGE_TIMEOUT to match SESSION_IDLE_DURATION#98
billyvg merged 1 commit intomainfrom
feat/change-visibility-change-timeout-match-session-idle

Conversation

@billyvg
Copy link
Copy Markdown
Member

@billyvg billyvg commented Jun 28, 2022

We are noticing a lot of short sessions that I suspect is related to the visibility change timeout. Keeping the code around and changing the constants in case we decide to tweak this later.

…ION`

We are noticing a lot of short sessions that I suspect is related to the visibility change timeout. Keeping the code around and changing the constants in case we decide to tweak this later.
@billyvg
Copy link
Copy Markdown
Member Author

billyvg commented Jun 28, 2022

Separated this from #94 as that PR has become a bit more complex than I intended.

@billyvg billyvg requested a review from ryan953 June 28, 2022 17:41
Copy link
Copy Markdown
Member

@ryan953 ryan953 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

longer timeout. :shipit:

@billyvg billyvg merged commit 796b1d9 into main Jun 29, 2022
@billyvg billyvg deleted the feat/change-visibility-change-timeout-match-session-idle branch June 29, 2022 13:20
mydea pushed a commit to getsentry/sentry-javascript that referenced this pull request Nov 23, 2022
…ION` (getsentry/sentry-replay#98)

We are noticing a lot of short sessions that I suspect is related to the visibility change timeout. Keeping the code around and changing the constants in case we decide to tweak this later.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants