This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Merged
Conversation
Refactor this handler so that we can re-use `addReplayEvent`. This will help us apply the same logic for our core SDK instrumentation handlers.
c4db660 to
00d7d67
Compare
billyvg
commented
Jun 2, 2022
Comment on lines
+312
to
+316
| // Suppress console.errors | ||
| jest.spyOn(console, 'error').mockImplementation(jest.fn()); | ||
| const mockConsole = console.error as jest.MockedFunction< | ||
| typeof console.error | ||
| >; |
Member
Author
There was a problem hiding this comment.
I changed this because otherwise console.error messages were being dumped into terminal when running tests. cc @Danondso
billyvg
commented
Jun 2, 2022
Comment on lines
+244
to
+247
| if (cb() === true) { | ||
| this.finishReplayEvent(); | ||
| return; | ||
| } |
Member
Author
There was a problem hiding this comment.
This is really the only thing that changed
JoshFerge
approved these changes
Jun 2, 2022
Member
JoshFerge
left a comment
There was a problem hiding this comment.
much cleaner great stuff 👍🏼
mydea
pushed a commit
to getsentry/sentry-javascript
that referenced
this pull request
Nov 23, 2022
Refactor this handler so that we can re-use `addReplayEvent`. This will help us apply the same logic for our core SDK instrumentation handlers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the batching logic into the method:
addReplayEvent. This will help us apply the same logic for our core SDK instrumentation handlers.