This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Conversation
9 tasks
size-limit report 📦
|
billyvg
approved these changes
Nov 16, 2022
Member
billyvg
left a comment
There was a problem hiding this comment.
How does sentry-javascript handle precommit hooks?
Member
Author
It doesn't, basically 😅 This is only enforced through tests/CI via |
Lms24
approved these changes
Nov 16, 2022
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Nov 23, 2022
As we do not have husky or an equivalent in sentry-javascript, we can remove this in preparation of the merge. NOTE: You have to make sure to run `rm -f .git/hooks` in your project dir in order to get rid of the hooks, if you've pulled this before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we do not have husky or an equivalent in sentry-javascript, we can remove this in preparation of the merge.
NOTE:
You have to make sure to run
rm -f .git/hooksin your project dir in order to get rid of the hooks, if you've pulled this before.