This repository was archived by the owner on Aug 30, 2023. It is now read-only.
chore: Pin node to 14.x to align with sentry-javascript#309
Merged
Conversation
746fa8f to
c0f4097
Compare
Lms24
approved these changes
Nov 16, 2022
78325bb to
e75c43b
Compare
c9542b5 to
3ab3ab4
Compare
size-limit report 📦
|
billyvg
approved these changes
Nov 16, 2022
9 tasks
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Nov 23, 2022
…ntry-replay#309) This downgrades node to 14.x to align with the node version used in sentry-javascript.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This downgrades node to 14.x to align with the node version used in sentry-javascript.
As far as I see everything still works normally, this is just to avoid unexpected surprises when merging this eventually ;)
Note that I also updated CI to use https://github.com/marketplace/actions/volta-cli-action directly to setup the correct node & yarn versions. (Note: I did not update the size.yml script, as there the action uses some npx stuff under the hood which does not play nicely with the volta action)