This repository was archived by the owner on Aug 30, 2023. It is now read-only.
fix: Treat sessions with segmentId:0 as new session#271
Merged
Conversation
size-limit report 📦
|
We have lots of replays that are missing `replay_start_timestamp` on segment 0. For some reason, some sessions with `segmentId:0` are not being considered a "new" session. Ideally we would fix this but for now, add some debug logging and forcefully treat session as "new" if after loading a session, it still has `segmentId:0`.
f8bbe46 to
570dd73
Compare
JoshFerge
approved these changes
Nov 3, 2022
mydea
pushed a commit
to getsentry/sentry-javascript
that referenced
this pull request
Nov 23, 2022
…ry-replay#271) We have lots of replays that are missing `replay_start_timestamp` on segment 0. For some reason, some sessions with `segmentId:0` are not being considered a "new" session. ~Ideally we would fix this but for now~, add some debug logging and forcefully treat session as "new" if after loading a session, it still has `segmentId:0`. I've gone ahead and removed the new session flag, as it's not needed, instead we can assume that segment 0 requires the start timestamp. Fixes getsentry/sentry#40984
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have lots of replays that are missing
replay_start_timestampon segment 0. For some reason, some sessions withsegmentId:0are not being considered a "new" session.Ideally we would fix this but for now, add some debug logging and forcefully treat session as "new" if after loading a session, it still hassegmentId:0.I've gone ahead and removed the new session flag, as it's not needed, instead we can assume that segment 0 requires the start timestamp.
Fixes getsentry/sentry#40984