feat(profiling): Add RN/Android mixed profiles by krystofwoldrich · Pull Request #3397 · getsentry/sentry-react-native

krystofwoldrich · 2023-11-15T11:52:23Z

📢 Type of change

New feature

📜 Description

This PR enabled the RN SDK to send Android Profiles with an attached SentryProfile. In this case a Hermes Profile.

The Java Module implementation depends on sentry-java changes:

💡 Motivation and Context

feat(profiling): Add Native iOS profiles to Hermes JS profiles #3349

💚 How did you test it?

RN sample app

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

Add JVM Debug Meta Images

Release:

Blocked by

Support Mixed Profiles RN/Android sentry#61142

…symbolicated-profiles

github-actions · 2023-11-29T11:03:24Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	432.08 ms	465.15 ms	33.07 ms
Size	17.73 MiB	19.85 MiB	2.11 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`12427f4`	393.69 ms	414.84 ms	21.14 ms
`5446992`	403.40 ms	426.70 ms	23.30 ms
`dadc233`+dirty	333.78 ms	343.94 ms	10.16 ms
`22e31b6`	396.48 ms	419.64 ms	23.16 ms
`f06c879`	408.41 ms	424.54 ms	16.13 ms
`b1e8712`	462.11 ms	465.71 ms	3.60 ms
`34aba08`	328.10 ms	342.84 ms	14.74 ms
`70caa60`+dirty	299.00 ms	321.02 ms	22.02 ms
`e73f4ed`+dirty	332.96 ms	354.33 ms	21.37 ms
`2534337`	394.15 ms	415.12 ms	20.97 ms

App size

Revision	Plain	With Sentry	Diff
`12427f4`	17.73 MiB	19.85 MiB	2.12 MiB
`5446992`	17.73 MiB	19.85 MiB	2.12 MiB
`dadc233`+dirty	17.73 MiB	19.75 MiB	2.02 MiB
`22e31b6`	17.73 MiB	19.84 MiB	2.10 MiB
`f06c879`	17.73 MiB	19.85 MiB	2.12 MiB
`b1e8712`	17.73 MiB	19.75 MiB	2.02 MiB
`34aba08`	17.73 MiB	19.80 MiB	2.07 MiB
`70caa60`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`e73f4ed`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`2534337`	17.73 MiB	19.84 MiB	2.11 MiB

github-actions · 2023-11-29T11:26:30Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	370.44 ms	407.56 ms	37.12 ms
Size	7.15 MiB	8.12 MiB	993.14 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`abb7058`+dirty	320.78 ms	324.08 ms	3.30 ms
`dadc233`+dirty	363.19 ms	370.37 ms	7.18 ms
`ad6c299`+dirty	336.47 ms	362.89 ms	26.42 ms
`d361d38`+dirty	257.72 ms	318.76 ms	61.04 ms
`e2b64fe`+dirty	258.82 ms	304.26 ms	45.44 ms
`e5c9b8b`+dirty	335.40 ms	360.06 ms	24.67 ms
`457e29f`+dirty	591.49 ms	612.96 ms	21.47 ms
`2534337`+dirty	597.14 ms	665.04 ms	67.90 ms
`70caa60`+dirty	308.83 ms	393.06 ms	84.23 ms
`5446992`+dirty	371.61 ms	390.00 ms	18.39 ms

App size

Revision	Plain	With Sentry	Diff
`abb7058`+dirty	7.15 MiB	8.10 MiB	980.40 KiB
`dadc233`+dirty	7.15 MiB	8.04 MiB	910.84 KiB
`ad6c299`+dirty	7.15 MiB	8.04 MiB	912.17 KiB
`d361d38`+dirty	7.15 MiB	8.08 MiB	959.34 KiB
`e2b64fe`+dirty	7.15 MiB	8.07 MiB	947.16 KiB
`e5c9b8b`+dirty	7.15 MiB	8.10 MiB	980.41 KiB
`457e29f`+dirty	7.15 MiB	8.10 MiB	981.29 KiB
`2534337`+dirty	7.15 MiB	8.11 MiB	988.68 KiB
`70caa60`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`5446992`+dirty	7.15 MiB	8.12 MiB	999.45 KiB

krystofwoldrich · 2023-11-29T11:40:33Z

This PR is ready to be reviewed.

Merge only after Sentry UI can display the JS profile attached to the Android profile.

Add note for Self hosted users to the changelog

…iling

viglia · 2024-01-23T16:29:49Z

@krystofwoldrich on the profiling (vroom) side you should be unblocked now.
I've merged this morning the last PR.

viglia

@krystofwoldrich at a high level it looks good.

@JonasBa can give a more detailed look at the js/ts profiler specifically.

Let me pull in @stefanosiano as well for the android profiler.

android/src/main/java/io/sentry/react/RNSentryModuleImpl.java

Krystof Woldrich added 30 commits October 11, 2023 13:18

feat(profiling): Send debug information with Profiles

7dff905

fix white space

f147e93

Add support for Hermes bytecode frames

5561dc7

Add changelog

fd0876e

Use bundle filename to lookup debugid

7e964ce

Remove unnecessary lookup logic as only one bundle is supported

073450f

Merge branch 'kw-add-hermes-profile-bytecode-frames-parsing' into kw-…

22eabf0

…symbolicated-profiles

Fix build

affcee8

Merge branch 'kw-add-hermes-profile-bytecode-frames-parsing' into kw-…

143d6e2

…symbolicated-profiles

Fix build

5dd4ea7

fix lint

81c2acb

Merge branch 'kw-add-hermes-profile-bytecode-frames-parsing' into kw-…

c3683f4

…symbolicated-profiles

fix lint

729876e

change profile platform to javascript

7d608fb

Mark root as in app false

102f1f1

Add new profile event handling and basic merge

f412a9e

fix merging transactions on profile, fix stacks id offset

9d8ef0a

Use sound types, better performance

c778e33

Add platform label to native profiles frames

e04fb7b

Use abs_path like error stacktrace frames

7e33cfa

Merge remote-tracking branch 'origin/main' into kw-symbolicated-profiles

66c2d58

Fix tests

4b1c004

Merge branch 'kw-symbolicated-profiles' into kw-mixed-profiling

3b73a95

remove duplicate types

facf3ed

Merge branch 'kw-symbolicated-profiles' into kw-mixed-profiling

f756790

fix ios codegen

5fde434

TMP: Fix sentry/types

3e900c6

Fix overwritten native debug meta images

be6a583

Merge remote-tracking branch 'origin/main' into kw-symbolicated-profiles

fff24a0

Merge branch 'kw-symbolicated-profiles' into kw-mixed-profiling

b1280fd

Krystof Woldrich added 3 commits November 17, 2023 17:14

Add proguard uuid

fe041f1

Merge branch 'main' into kw-android-mixed-profiling

65e36a7

fix ts types

04a6259

krystofwoldrich added the Blocked label Nov 29, 2023

Add max profile size

4759050

krystofwoldrich mentioned this pull request Dec 5, 2023

Support Mixed Profiles RN/Android getsentry/sentry#61142

Closed

Krystof Woldrich added 3 commits December 5, 2023 18:12

Merge remote-tracking branch 'origin/main' into kw-android-mixed-prof…

b078c12

…iling

Make Release build of sample app debuggable

a181842

Fix missing build_id use assets debug meta loader

e44ecf5

Merge branch 'main' into kw-android-mixed-profiling

3294806

krystofwoldrich marked this pull request as ready for review January 30, 2024 16:49

krystofwoldrich requested a review from lucas-zimerman as a code owner January 30, 2024 16:49

Krystof Woldrich added 2 commits January 31, 2024 11:15

fix profiler sample rate

2ce4fe7

fix changelog

a19387d

krystofwoldrich removed the Blocked label Jan 31, 2024

krystofwoldrich requested review from JonasBa and viglia January 31, 2024 10:58

viglia reviewed Jan 31, 2024

View reviewed changes

stefanosiano reviewed Feb 5, 2024

View reviewed changes

android/src/main/java/io/sentry/react/RNSentryModuleImpl.java Show resolved Hide resolved

stefanosiano approved these changes Feb 6, 2024

View reviewed changes

krystofwoldrich added 2 commits February 8, 2024 11:19

Merge branch 'main' into kw-android-mixed-profiling

66f2c44

Update CHANGELOG.md

1056f4a

krystofwoldrich enabled auto-merge (squash) February 12, 2024 09:35

krystofwoldrich merged commit 7835531 into main Feb 12, 2024

krystofwoldrich deleted the kw-android-mixed-profiling branch February 12, 2024 09:37

krystofwoldrich mentioned this pull request Feb 12, 2024

fix(android): proguardUuid loading #3591

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(profiling): Add RN/Android mixed profiles#3397

feat(profiling): Add RN/Android mixed profiles#3397
krystofwoldrich merged 72 commits intomainfrom
kw-android-mixed-profiling

krystofwoldrich commented Nov 15, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Nov 29, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Nov 29, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Uh oh!

krystofwoldrich commented Nov 29, 2023

Uh oh!

viglia commented Jan 23, 2024

Uh oh!

viglia left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

krystofwoldrich commented Nov 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Release:

Blocked by

Uh oh!

github-actions bot commented Nov 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Nov 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

krystofwoldrich commented Nov 29, 2023

Uh oh!

viglia commented Jan 23, 2024

Uh oh!

viglia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

krystofwoldrich commented Nov 15, 2023 •

edited

Loading

github-actions bot commented Nov 29, 2023 •

edited

Loading

github-actions bot commented Nov 29, 2023 •

edited

Loading