fix(fileutils): Add readBytesFromFile for use in Hybrid SDKs#3052
Merged
krystofwoldrich merged 4 commits intomainfrom Nov 17, 2023
Merged
fix(fileutils): Add readBytesFromFile for use in Hybrid SDKs#3052krystofwoldrich merged 4 commits intomainfrom
readBytesFromFile for use in Hybrid SDKs#3052krystofwoldrich merged 4 commits intomainfrom
Conversation
12 tasks
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 283d83e | 348.44 ms | 392.06 ms | 43.62 ms |
| c7e2fbc | 377.85 ms | 426.35 ms | 48.50 ms |
| 93a76ca | 391.54 ms | 475.65 ms | 84.11 ms |
| 86f0096 | 371.86 ms | 439.78 ms | 67.92 ms |
| 93a76ca | 377.96 ms | 447.52 ms | 69.56 ms |
| c7e2fbc | 398.35 ms | 468.52 ms | 70.17 ms |
| c3f503e | 360.41 ms | 434.67 ms | 74.27 ms |
| a3c77bc | 375.80 ms | 445.85 ms | 70.06 ms |
| 99a51e2 | 405.11 ms | 479.65 ms | 74.54 ms |
| 3d8bd2b | 375.34 ms | 446.32 ms | 70.98 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 283d83e | 1.72 MiB | 2.29 MiB | 577.69 KiB |
| c7e2fbc | 1.72 MiB | 2.29 MiB | 576.40 KiB |
| 93a76ca | 1.72 MiB | 2.29 MiB | 576.75 KiB |
| 86f0096 | 1.72 MiB | 2.29 MiB | 576.50 KiB |
| 93a76ca | 1.72 MiB | 2.29 MiB | 576.75 KiB |
| c7e2fbc | 1.72 MiB | 2.29 MiB | 576.40 KiB |
| c3f503e | 1.72 MiB | 2.29 MiB | 577.04 KiB |
| a3c77bc | 1.72 MiB | 2.29 MiB | 577.53 KiB |
| 99a51e2 | 1.72 MiB | 2.29 MiB | 576.34 KiB |
| 3d8bd2b | 1.72 MiB | 2.29 MiB | 577.53 KiB |
Previous results on branch: kw-move-readbytes-to-fileutils
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6d9bd2b | 355.53 ms | 460.74 ms | 105.21 ms |
| dc345fe | 367.43 ms | 453.78 ms | 86.35 ms |
| 3e6582d | 375.41 ms | 446.68 ms | 71.27 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6d9bd2b | 1.72 MiB | 2.29 MiB | 578.13 KiB |
| dc345fe | 1.72 MiB | 2.29 MiB | 578.14 KiB |
| 3e6582d | 1.72 MiB | 2.29 MiB | 578.14 KiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
This PR moves
readBytesFromFilefromEnvelopeItemtoFileUtilsto share this code with Hybrid SDKs.💡 Motivation and Context
With this change, we avoid duplicate code in RN Java Module.
💚 How did you test it?
RN sample app
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps