feat: Allow configuring keep_alive via environment variable#4366
Merged
szokeasaurusrex merged 1 commit intomasterfrom May 19, 2025
Merged
feat: Allow configuring keep_alive via environment variable#4366szokeasaurusrex merged 1 commit intomasterfrom
keep_alive via environment variable#4366szokeasaurusrex merged 1 commit intomasterfrom
Conversation
szokeasaurusrex
commented
May 6, 2025
|
| Tests completed | Failed | Passed | Skipped |
|---|---|---|---|
| 23654 | 4 | 23650 | 5865 |
View the top 3 failed test(s) by shortest run time
tests.integrations.redis.cluster.test_redis_cluster::test_rediscluster_pipeline[False-expected_first_ten0]Stack Traces | 0.09s run time
.../redis/cluster/test_redis_cluster.py:131: in test_rediscluster_pipeline assert span["data"] == ApproxDict( E assert {'thread.id': '139788412963712', 'thread.name': 'MainThread', 'db.system': 'redis', 'server.address': '127.0.0.1', 'server.port': 6379, 'redis.commands': {'count': 0, 'first_ten': []}} == {'redis.commands': {'count': 3, 'first_ten': ["GET 'foo'", "SET 'bar' [Filtered]", "SET 'baz' [Filtered]"]}, 'db.system': 'redis', 'server.address': '127.0.0.1', 'server.port': 6379} E Common items: E {'db.system': 'redis', 'server.address': '127.0.0.1', 'server.port': 6379} E Differing items: E {'redis.commands': {'count': 0, 'first_ten': []}} != {'redis.commands': {'count': 3, 'first_ten': ["GET 'foo'", "SET 'bar' [Filtered]", "SET 'baz' [Filtered]"]}} E Left contains 2 more items: E {'thread.id': '139788412963712', 'thread.name': 'MainThread'} E Full diff: E { E 'db.system': 'redis', E - 'redis.commands': {'count': 3, E ? ^ E + 'redis.commands': {'count': 0, E ? ^ E - 'first_ten': ["GET 'foo'", E ? ^^^^^^^^^^^ E + 'first_ten': []}, E ? ^^ E - "SET 'bar' [Filtered]", E - "SET 'baz' [Filtered]"]}, E 'server.address': '127.0.0.1', E 'server.port': 6379, E + 'thread.id': '139788412963712', E + 'thread.name': 'MainThread', E }
tests.integrations.redis.cluster.test_redis_cluster::test_rediscluster_pipeline[True-expected_first_ten1]Stack Traces | 0.091s run time
.../redis/cluster/test_redis_cluster.py:131: in test_rediscluster_pipeline assert span["data"] == ApproxDict( E assert {'thread.id': '139788412963712', 'thread.name': 'MainThread', 'db.system': 'redis', 'server.address': '127.0.0.1', 'server.port': 6379, 'redis.commands': {'count': 0, 'first_ten': []}} == {'redis.commands': {'count': 3, 'first_ten': ["GET 'foo'", "SET 'bar' 1", "SET 'baz' 2"]}, 'db.system': 'redis', 'server.address': '127.0.0.1', 'server.port': 6379} E Common items: E {'db.system': 'redis', 'server.address': '127.0.0.1', 'server.port': 6379} E Differing items: E {'redis.commands': {'count': 0, 'first_ten': []}} != {'redis.commands': {'count': 3, 'first_ten': ["GET 'foo'", "SET 'bar' 1", "SET 'baz' 2"]}} E Left contains 2 more items: E {'thread.id': '139788412963712', 'thread.name': 'MainThread'} E Full diff: E { E 'db.system': 'redis', E - 'redis.commands': {'count': 3, E ? ^ E + 'redis.commands': {'count': 0, E ? ^ E - 'first_ten': ["GET 'foo'", E ? ^^^^^^^^^^^ E + 'first_ten': []}, E ? ^^ E - "SET 'bar' 1", E - "SET 'baz' 2"]}, E 'server.address': '127.0.0.1', E 'server.port': 6379, E + 'thread.id': '139788412963712', E + 'thread.name': 'MainThread', E }
tests.integrations.redis.cluster.test_redis_cluster::test_rediscluster_pipeline[True-expected_first_ten1]Stack Traces | 0.094s run time
.../redis/cluster/test_redis_cluster.py:131: in test_rediscluster_pipeline assert span["data"] == ApproxDict( E assert {'thread.id': '140331044162432', 'thread.name': 'MainThread', 'db.system': 'redis', 'server.address': '127.0.0.1', 'server.port': 6379, 'redis.commands': {'count': 0, 'first_ten': []}} == {'redis.commands': {'count': 3, 'first_ten': ["GET 'foo'", "SET 'bar' 1", "SET 'baz' 2"]}, 'db.system': 'redis', 'server.address': '127.0.0.1', 'server.port': 6379} E Common items: E {'db.system': 'redis', 'server.address': '127.0.0.1', 'server.port': 6379} E Differing items: E {'redis.commands': {'count': 0, 'first_ten': []}} != {'redis.commands': {'count': 3, 'first_ten': ["GET 'foo'", "SET 'bar' 1", "SET 'baz' 2"]}} E Left contains 2 more items: E {'thread.id': '140331044162432', 'thread.name': 'MainThread'} E Full diff: E { E 'db.system': 'redis', E - 'redis.commands': {'count': 3, E ? ^ E + 'redis.commands': {'count': 0, E ? ^ E - 'first_ten': ["GET 'foo'", E ? ^^^^^^^^^^^ E + 'first_ten': []}, E ? ^^ E - "SET 'bar' 1", E - "SET 'baz' 2"]}, E 'server.address': '127.0.0.1', E 'server.port': 6379, E + 'thread.id': '140331044162432', E + 'thread.name': 'MainThread', E }
To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.
antonpirker
approved these changes
May 6, 2025
Contributor
antonpirker
left a comment
There was a problem hiding this comment.
see my comments, otherwise looks good!
This commit enables the `keep_alive` option to be set via the `SENTRY_KEEP_ALIVE` environment variable. When both the environment variable and the argument are provided, the argument takes precedence. Closes #4354
dacb5b1 to
8ab796c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit enables the
keep_aliveoption to be set via theSENTRY_KEEP_ALIVEenvironment variable. When both the environment variable and the argument are provided, the argument takes precedence.Closes #4354