Update tox setup for AWS Lambda integration#4076
Merged
antonpirker merged 11 commits intoantonpirker/better-aws-testsfrom Feb 24, 2025
Merged
Update tox setup for AWS Lambda integration#4076antonpirker merged 11 commits intoantonpirker/better-aws-testsfrom
antonpirker merged 11 commits intoantonpirker/better-aws-testsfrom
Conversation
2cde31a to
a89b3c4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## antonpirker/better-aws-tests #4076 +/- ##
================================================================
+ Coverage 79.46% 79.49% +0.03%
================================================================
Files 140 140
Lines 15521 15521
Branches 2631 2631
================================================================
+ Hits 12334 12339 +5
+ Misses 2353 2351 -2
+ Partials 834 831 -3 |
sentrivana
approved these changes
Feb 24, 2025
Contributor
sentrivana
left a comment
There was a problem hiding this comment.
#feelsgood
There is couple more aws-* scripts in scripts/, do we still need any of those?
Contributor
Author
|
Those scripts are still needed if someone is doing manual testing (creating a Lambda function by hand and wanting to add the Layer to it and stuff like this) I cleaned the |
antonpirker
added a commit
that referenced
this pull request
Mar 12, 2025
Test Sentry AWS Lambda integration locally instead of creating actual Lambda function in AWS: - Create a local AWS Lambda environment using AWS SAM and AWS CDK. (Docker based) - Start a local Sentry server that accepts envelopes. - Run the tests in the local AWS Lambda environment configured with a DSN that tells the SDK to send data to the local Sentry server. - Read the captured envelopes from the local Sentry server to assert their correctness. - Update CI configuration, so AWS tests are now handled the same as test suite matrices of other integrations. There is also a follow-up PR that removes obsolete code handling AWS authentication data: #4076 (This PR will also fix the one failing test) Fixes #2795
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because we changed our AWS Lambda test suite to not create real Lambda functions but rather run a Lambda environment locally, we do not need all the code necessary for handling the authentication to AWS in the test suite.
This PR removes all the AWS auth related code and als moves the AWS Lambda testsuite again into the "Cloud" group of test suites, because it is a "normal" test suite again.
The PR that includes the change to have a local Lambda environment is here: #3988