Skip to content

feat(flags): add Statsig integration#4022

Merged
aliu39 merged 11 commits intomasterfrom
aliu/statsig
Feb 12, 2025
Merged

feat(flags): add Statsig integration#4022
aliu39 merged 11 commits intomasterfrom
aliu/statsig

Conversation

@aliu39
Copy link
Member

@aliu39 aliu39 commented Feb 8, 2025

New integration for tracking Statsig (pypi) flag evaluations, specifically the checkGate method which is used for boolean release flags. Unlike JS, there's no support for event callbacks for Statsig's server SDKs. Instead we wrap the module-level check_gate function.

Ref https://develop.sentry.dev/sdk/expected-features/#feature-flags

Ref

@codecov
Copy link

codecov bot commented Feb 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.26%. Comparing base (b2fc801) to head (f2ca15d).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/statsig.py 84.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4022      +/-   ##
==========================================
- Coverage   80.26%   80.26%   -0.01%     
==========================================
  Files         139      140       +1     
  Lines       15417    15442      +25     
  Branches     2606     2608       +2     
==========================================
+ Hits        12374    12394      +20     
- Misses       2203     2207       +4     
- Partials      840      841       +1
Files with missing lines Coverage Δ
sentry_sdk/integrations/__init__.py 77.01% <ø> (ø)
sentry_sdk/integrations/unleash.py 90.00% <ø> (ø)
sentry_sdk/integrations/statsig.py 84.00% <84.00%> (ø)

... and 1 file with indirect coverage changes

@aliu39 aliu39 added the New Integration Integrating with a new framework or library label Feb 8, 2025
cmanallen
cmanallen approved these changes Feb 10, 2025
View reviewed changes
@aliu39 aliu39 requested review from a team February 11, 2025 21:05
@aliu39
Copy link
Member Author

aliu39 commented Feb 11, 2025

May need some help debugging the failed CI.. it's warning about unknown config options found in pytest.ini: asyncio_mode and asyncio_default_fixture_loop_scope

sentrivana
sentrivana approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@sentrivana sentrivana left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folks, this looks good to me. I fixed up the test setup a bit and added a minimum version check to the integration (set to 0.55.3). Feel free to merge if the changes look good to you.

@sentrivana
Copy link
Contributor

sentrivana commented Feb 12, 2025

We will also need integration docs for this -- anyone on it already? Otherwise I'll whip something up

@aliu39
Copy link
Member Author

aliu39 commented Feb 12, 2025

We will also need integration docs for this -- anyone on it already? Otherwise I'll whip something up

I was planning to whip one up tomorrow or friday!

@aliu39 aliu39 merged commit 7a1c010 into master Feb 12, 2025
151 checks passed
@aliu39 aliu39 deleted the aliu/statsig branch February 12, 2025 17:55
@aliu39 aliu39 mentioned this pull request Feb 13, 2025
Merged
This was referenced Feb 27, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmanallen cmanallen cmanallen approved these changes

@sentrivana sentrivana sentrivana approved these changes

@antonpirker antonpirker Awaiting requested review from antonpirker

Assignees

No one assigned

Labels

New Integration Integrating with a new framework or library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aliu39 @sentrivana @cmanallen