Skip to content

[9] Move the Network group over to the tox gen script#3979

Merged
sentrivana merged 19 commits intomasterfrom
ivana/tox-script-9
Feb 14, 2025
Merged

[9] Move the Network group over to the tox gen script#3979
sentrivana merged 19 commits intomasterfrom
ivana/tox-script-9

Conversation

@sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jan 20, 2025 •
edited
Loading

  • remove hardcoded entries for requests, grpc from the tox template
  • remove them from the ignore list in populate_tox.py
  • run populate_tox.py to fill in entries for them
  • run split_gh_tox_actions.py to generate the CI yaml files so that they correspond to the new tox.ini

The remaining integrations in this group are not trivial to port to the script, I'll do this step by step in follow-up PRs.

@codecov
Copy link

codecov bot commented Jan 20, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
22818 1 22817 5781
View the full list of 1 ❄️ flaky tests 
tests.integrations.stdlib.test_httplib test_http_timeout

Flake rate in main: 11.76% (Passed 15 times, Failed 2 times)

Stack Traces | 0.209s run time 
.../integrations/stdlib/test_httplib.py:419: in test_http_timeout
    assert len(transaction["spans"]) == 1
E   assert 0 == 1
E    +  where 0 = len([])

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Base automatically changed from ivana/tox-script-4 to master February 11, 2025 10:26
szokeasaurusrex
szokeasaurusrex reviewed Feb 13, 2025
View reviewed changes
.github/workflows/test-integrations-network.yml
fail-fast: false
matrix:
python-version: ["3.8","3.9","3.11","3.12","3.13"]
python-version: ["3.9","3.12","3.13"]
Copy link
Member

@szokeasaurusrex szokeasaurusrex Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be concerned that tests for 3.8 and 3.11 are gone?

Copy link
Contributor Author

@sentrivana sentrivana Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same reply as in the other PRs -- we're shrinking the Latest group by taking stuff out of it. So this is ok. It's all moving into the Pinned group instead.

tox.ini


# ~~~ Network ~~~
{py3.7,py3.8}-grpc-v1.32.0
Copy link
Member

@szokeasaurusrex szokeasaurusrex Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the .github/workflows, we don't have either of these Python versions. Is that because the line changed in this PR is for the latest tests?

Copy link
Contributor Author

@sentrivana sentrivana Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you have to look at Python versions in the Pinned group instead, that's what gets generated by this script.

@sentrivana sentrivana enabled auto-merge (squash) February 14, 2025 12:48
@sentrivana sentrivana merged commit 7b5904a into master Feb 14, 2025
142 checks passed
@sentrivana sentrivana deleted the ivana/tox-script-9 branch February 14, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szokeasaurusrex szokeasaurusrex szokeasaurusrex approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sentrivana @szokeasaurusrex