fix(profiling): Use type() instead when extracting frames#3716
Merged
fix(profiling): Use type() instead when extracting frames#3716
type() instead when extracting frames#3716Conversation
When extract frame names, we should avoid accessing the `__class__` attribute as it can be overwritten in the class implementation. In this particular instance, the `SimpleLazyObject` class in django wraps `__class__` so when it is accessed, it can cause the underlying lazy object to be evaluation unexpectedly. To avoid this, use the `type()` builtin function which does cannot be overwritten and will return the correct class. Note that this does not work with old style classes but since dropping python 2 support, we only need to consider new style classes.
6597c19 to
95303b5
Compare
sl0thentr0py
approved these changes
Oct 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3716 +/- ##
==========================================
- Coverage 84.28% 83.28% -1.00%
==========================================
Files 133 133
Lines 14257 14432 +175
Branches 2405 2457 +52
==========================================
+ Hits 12016 12020 +4
- Misses 1490 1662 +172
+ Partials 751 750 -1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When extract frame names, we should avoid accessing the
__class__attribute as it can be overwritten in the class implementation. In this particular instance, theSimpleLazyObjectclass in django wraps__class__so when it is accessed, it can cause the underlying lazy object to be evaluation unexpectedly. To avoid this, use thetype()builtin function which cannot be overwritten and will return the correct class.Note that this does not work with old style classes but since dropping python 2 support, we only need to consider new style classes.