fix(strawberry): prepare for upstream extension removal#3649
Merged
sentrivana merged 2 commits intogetsentry:masterfrom Oct 22, 2024
Merged
Conversation
744f8e9 to
6f2c648
Compare
sentrivana
approved these changes
Oct 22, 2024
Contributor
sentrivana
left a comment
There was a problem hiding this comment.
Thank you @DoctorJohn. Looks good to me.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3649 +/- ##
==========================================
- Coverage 84.36% 84.29% -0.07%
==========================================
Files 133 133
Lines 14227 14231 +4
Branches 2398 2398
==========================================
- Hits 12002 11996 -6
- Misses 1482 1496 +14
+ Partials 743 739 -4
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by @szokeasaurusrex in strawberry-graphql/strawberry#3590, Strawberry is preparing to fully remove its deprecated
SentryTracingExtensionin favor of the integration provided by the Sentry SDK.This PR prepares the Sentry Strawberry integration for that removal by:
I also checked that removing the extension does not otherwise affect the integration: The extension's sync and async variants are imported to replace them and to guess whether sync or async code is used. Both still works if the imports are defaulted to
None.