feat: Add SENTRY_SPOTLIGHT env variable support#3443
Merged
sentrivana merged 10 commits intogetsentry:masterfrom Aug 14, 2024
BYK:byk/feat/SENTRY_SPOTLIGHT
Merged
feat: Add SENTRY_SPOTLIGHT env variable support#3443sentrivana merged 10 commits intogetsentry:masterfrom BYK:byk/feat/SENTRY_SPOTLIGHT
sentrivana merged 10 commits intogetsentry:masterfrom
BYK:byk/feat/SENTRY_SPOTLIGHT
Conversation
Allows setting Spotlight through `$SENTRY_SPOTLIGHT` env variable.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3443 +/- ##
==========================================
- Coverage 79.80% 79.73% -0.08%
==========================================
Files 134 134
Lines 14522 14530 +8
Branches 3056 3059 +3
==========================================
- Hits 11589 11585 -4
- Misses 2097 2112 +15
+ Partials 836 833 -3
|
sentrivana
reviewed
Aug 13, 2024
Contributor
There was a problem hiding this comment.
@BYK Thanks for this! Can you please also add a test to https://github.com/getsentry/sentry-python/blob/master/tests/test_spotlight.py?
Member
Author
|
Will add tests and then will request a re-review. |
Member
Author
|
Finally, ready for the final round |
arjennienhuis
pushed a commit
to arjennienhuis/sentry-python
that referenced
this pull request
Sep 30, 2024
Allows setting Spotlight through `$SENTRY_SPOTLIGHT` env variable. --------- Co-authored-by: Burak Yigit Kaya <bkaya21@bloomberg.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows setting Spotlight through
$SENTRY_SPOTLIGHTenv variable.Part of getsentry/spotlight#482