ref(pymongo): Remove redundant command name in query description#3189
Merged
antonpirker merged 2 commits intomasterfrom Jun 21, 2024
Merged
ref(pymongo): Remove redundant command name in query description#3189antonpirker merged 2 commits intomasterfrom
antonpirker merged 2 commits intomasterfrom
Conversation
Contributor
|
But then when I look at the span tree, I do not know which command was run, right? So I always have to click into the span and find |
Contributor
|
But if otel does it this way, then we probably need to update the span tree, to display |
antonpirker
approved these changes
Jun 21, 2024
Contributor
|
But this is something that "future us" need to do :-) |
Contributor
Author
|
@antonpirker Thanks for the review! You won't always have to click on the span to see the operation, since in most cases, the operation is the first key in the JSON, which you can see in the span description. It seems like the operation isn't included only when it's an insert |
arjennienhuis
pushed a commit
to arjennienhuis/sentry-python
that referenced
this pull request
Sep 30, 2024
…sentry#3189) The query command is already included as the first key within the command JSON, so query spans end up having the command twice in the desription.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The query command is already included as the first key within the command JSON, so query spans would end up looking like this:
Our Node SDK, which uses OTel under the hood now, formats queries differently; it doesn't include the command name at the front, example:
We also already include the command within the
db.operationtag, so there's no confusion or loss of details here. This change will ensure consistent behaviour between our other SDKs!