Skip to content

Add deprecation comment for profiler internals#3167

Merged
sentrivana merged 2 commits intomasterfrom
ivana/deprecate-profiler-interface
Jun 13, 2024
Merged

Add deprecation comment for profiler internals#3167
sentrivana merged 2 commits intomasterfrom
ivana/deprecate-profiler-interface

Conversation

@sentrivana
Copy link
Copy Markdown
Contributor

These symbols were never explicitly part of the public API, but they were also not explicitly marked as private, so out of abundance of caution we kept them around as importable straight from sentry_sdk.profiler when reorganizing modules in the scope of #2830. However, since they were never meant to be public, we want to remove them from the implicitly public API, so we deprecate them here.

This also needs to be called out in the changelog.

@sentrivana sentrivana enabled auto-merge (squash) June 13, 2024 14:08
Copy link
Copy Markdown
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

@sentrivana sentrivana merged commit 0878593 into master Jun 13, 2024
@sentrivana sentrivana deleted the ivana/deprecate-profiler-interface branch June 13, 2024 14:25
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants