Refactored the Celery Beat integration.#3105
Merged
sentrivana merged 6 commits intomasterfrom Jun 3, 2024
Merged
Conversation
sentrivana
approved these changes
May 29, 2024
Contributor
sentrivana
left a comment
There was a problem hiding this comment.
LGTM. Awesome dedup of the scheduler code too 👍🏻
szokeasaurusrex
added a commit
that referenced
this pull request
Jun 7, 2024
This reverts commit c80cad1.
szokeasaurusrex
added a commit
that referenced
this pull request
Jun 7, 2024
antonpirker
added a commit
that referenced
this pull request
Jun 17, 2024
antonpirker
added a commit
that referenced
this pull request
Jun 18, 2024
This reverts the revert that was done to mitigate the regression error with Crons not being sending ok/error checkins. This reapplies the refactoring and also fixes the root cause of the regression and also adds integration tests to make sure it does not happen again.
sentrivana
pushed a commit
that referenced
this pull request
Jun 19, 2024
This reverts the revert that was done to mitigate the regression error with Crons not being sending ok/error checkins. This reapplies the refactoring and also fixes the root cause of the regression and also adds integration tests to make sure it does not happen again.
arjennienhuis
pushed a commit
to arjennienhuis/sentry-python
that referenced
this pull request
Sep 30, 2024
arjennienhuis
pushed a commit
to arjennienhuis/sentry-python
that referenced
this pull request
Sep 30, 2024
…ntry#3144) This reverts commit c80cad1, which appears to have introduced a regression preventing checkins from being sent when a cron job is finished.
arjennienhuis
pushed a commit
to arjennienhuis/sentry-python
that referenced
this pull request
Sep 30, 2024
…entry#3144) (getsentry#3175) This reverts the revert that was done to mitigate the regression error with Crons not being sending ok/error checkins. This reapplies the refactoring and also fixes the root cause of the regression and also adds integration tests to make sure it does not happen again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making it:
Small docs update to make it clear how trace propagation in Celery works:
getsentry/sentry-docs#10161