Skip to content

Huggingface Hub integration#3033

Merged
antonpirker merged 3 commits intomasterfrom
huggingface
May 2, 2024
Merged

Huggingface Hub integration#3033
antonpirker merged 3 commits intomasterfrom
huggingface

Conversation

@colin-sentry
Copy link
Copy Markdown
Contributor

@colin-sentry colin-sentry commented Apr 30, 2024

Adds integration for Huggingface Hub.

Copy link
Copy Markdown
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! 🔥

# To avoid double collecting tokens, we do *not* measure
# token counts for models for which we have an explicit integration
NO_COLLECT_TOKEN_MODELS = ["openai-chat"]
NO_COLLECT_TOKEN_MODELS = ["openai-chat"] # TODO add huggingface and anthropic
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not adding huggingface now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants