Skip to content

Set task ID on span (Celery integration)#3015

Merged
szokeasaurusrex merged 1 commit intoszokeasaurusrex/celery-retry-countfrom
szokeasaurusrex/celery-messaging-id
May 15, 2024
Merged

Set task ID on span (Celery integration)#3015
szokeasaurusrex merged 1 commit intoszokeasaurusrex/celery-retry-countfrom
szokeasaurusrex/celery-messaging-id

Conversation

@szokeasaurusrex
Copy link
Copy Markdown
Member

@szokeasaurusrex szokeasaurusrex commented Apr 25, 2024 •
edited
Loading

@szokeasaurusrex szokeasaurusrex linked an issue Apr 25, 2024 that may be closed by this pull request
Send Celery Message ID #2974
Closed
@szokeasaurusrex szokeasaurusrex mentioned this pull request Apr 25, 2024
Closed
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review April 25, 2024 10:09
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/celery-queue-consumer-default-exchange branch from 2fea931 to 3bf4c12 Compare April 26, 2024 10:18
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/celery-messaging-id branch from e3d378d to 294bdaa Compare April 26, 2024 10:23
antonpirker
antonpirker approved these changes Apr 30, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/celery-queue-consumer-default-exchange branch from f1671f5 to 67e2531 Compare April 30, 2024 15:16
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/celery-messaging-id branch from 294bdaa to d5a29b9 Compare April 30, 2024 15:22
@szokeasaurusrex szokeasaurusrex changed the base branch from szokeasaurusrex/celery-queue-consumer-default-exchange to szokeasaurusrex/celery-retry-count April 30, 2024 15:42
@szokeasaurusrex szokeasaurusrex mentioned this pull request Apr 30, 2024
Merged
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/celery-messaging-id branch from d5a29b9 to df18b49 Compare May 7, 2024 15:56
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/celery-retry-count branch from 42f3b19 to 6ed9bf7 Compare May 10, 2024 12:29
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/celery-messaging-id branch from df18b49 to 9af5324 Compare May 10, 2024 12:30
@szokeasaurusrex
feat(celery): Set task ID on span
68332d8 
Set Celery task ID on the "queue.process" span, and add tests for this new behavior.

Closes #2974
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/celery-retry-count branch from 6ed9bf7 to ff10b77 Compare May 15, 2024 12:22
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/celery-messaging-id branch from 9af5324 to 68332d8 Compare May 15, 2024 12:22
@szokeasaurusrex szokeasaurusrex merged commit 68332d8 into szokeasaurusrex/celery-retry-count May 15, 2024
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/celery-messaging-id branch May 15, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edwardgou-sentry edwardgou-sentry edwardgou-sentry approved these changes

+1 more reviewer

@antonpirker antonpirker antonpirker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Send Celery Message ID

3 participants

@szokeasaurusrex @antonpirker @edwardgou-sentry