Skip to content

Make Scope.update_from_* appear in apidocs#2311

Merged
sentrivana merged 2 commits intomasterfrom
ivana/add-missing-function-doc
Aug 17, 2023
Merged

Make Scope.update_from_* appear in apidocs#2311
sentrivana merged 2 commits intomasterfrom
ivana/add-missing-function-doc

Conversation

@sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Aug 17, 2023

The docstrings themselves don't really add much value but including them makes the methods appear in our apidocs.

Fixes #2309

This makes the methods appear in our apidocs.
@sentrivana sentrivana requested a review from antonpirker August 17, 2023 08:18
@sentrivana sentrivana changed the title Add docstrings for Scope.update_from_* Make Scope.update_from_* appear in apidocs Aug 17, 2023
@sentrivana sentrivana self-assigned this Aug 17, 2023
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sentrivana sentrivana merged commit b2c9af9 into master Aug 17, 2023
@sentrivana sentrivana deleted the ivana/add-missing-function-doc branch August 17, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs reference Scope.update_from_kwargs, but it is undocumented

2 participants