test(threading): Add spec for ThreadPoolExecutor#2259
Conversation
`ThreadPool` also obeys hub propagation, but there was no spec for it.
|
will fix the 2.7 stuff |
|
alright that works too |
|
@sl0thentr0py I keep playing whack-a-mole with old Python versions 😅 I copy-pasted from other specs for now, but some stuff is still failing. What's the right way to do things like |
|
pushed fix, we always do an |
|
@sl0thentr0py ugh, sorry, one more mysterious failure! Something is wrong in |
|
waddafaq, looking |
|
obviously it works on my machine |
|
@antonpirker whatever you did, it seems like it worked? Was the test failure just a weird flake of some kind? |
|
@sl0thentr0py @antonpirker what do you think, is this PR good to merge? Is it even worth it? |
|
Hey @gggritso |
|
@antonpirker awesome, thanks! |
ThreadPoolExecutoralso obeys hub propagation, but there wasn't a spec for it. This PR adds a bit more coverage.