Skip to content

Revert partial hack, but keep docs#2224

Merged
sentrivana merged 2 commits intomasterfrom
ivana/remove-kwargs-hack
Jul 4, 2023
Merged

Revert partial hack, but keep docs#2224
sentrivana merged 2 commits intomasterfrom
ivana/remove-kwargs-hack

Conversation

@sentrivana
Copy link
Copy Markdown
Contributor

@sentrivana sentrivana commented Jul 4, 2023

The partial hack enabled us to have nicer sphinx docs, but broke any autocompletion in PyCharm.

@sentrivana sentrivana requested a review from antonpirker July 4, 2023 11:28
Copy link
Copy Markdown
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sentrivana sentrivana merged commit d8a81a9 into master Jul 4, 2023
@sentrivana sentrivana deleted the ivana/remove-kwargs-hack branch July 4, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants