Load AWS Lambda secrets in Github CI#2153
Merged
antonpirker merged 67 commits intomasterfrom Oct 30, 2023
Merged
Conversation
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
sentrivana
approved these changes
Oct 25, 2023
Contributor
sentrivana
left a comment
There was a problem hiding this comment.
Looks good to me!
Awesome that you've fixed this. 🎖️
Left a few small comments.
…openssl problems in lambda layers.
sentrivana
reviewed
Oct 25, 2023
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure our AWS Lambda test setup is correct and the tests work as expected and also in a timely manner.
We run our test in AWS Lambda and then parse the log output to see what events/envelopes where sent. Because Lambda truncates this log output to 4kb, I had to change the tests to make the events/envelopes smaller in size to get the whole event/envelop in the log output.
When the AWS env vars where not set, the tests where skipped but it looked like they where successful. I made them now fail loudly in that case, so we see if they do not run.
Also made the code easier to comprehend.
Somehow related docs PR: getsentry/sentry-docs#8246
If this has been merged AND released, this PR in
sentrycan be merged: getsentry/sentry#58321