Import Markup from markupsafe#2047
Merged
sentrivana merged 5 commits intogetsentry:masterfrom May 12, 2023
Merged
Conversation
Flask v2.3.0 deprecates importing Markup from flask, indicating that it should be imported from markupsafe instead.
|
Hit this issue as well, reference for change in Flask that led to this being necessary pallets/flask#4996 |
Contributor
|
Thanks for the fix @rco-ableton I have started the CI jobs, lets see if all the tests are green. (If not, could you please fix them?) |
Contributor
Author
I'd be happy to if I'm able, but right now there still seem to be 10 pending checks that haven't reported their status for a while now. Are they stuck? |
sentrivana
approved these changes
May 12, 2023
Contributor
|
I've moved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a
DeprecationWarningwhen using Flask v2.3.0 or later (actually, it breaks completely withflask==2.3.0, but that's down to a mistake in the Flask project. Some tests are failing for me locally, but the same tests are failing on themasterbranch so hopefully that's just something peculiar to my machine.See Flask's release notes for more context.