fix(integration): fix FlaskIntegration for Werkzeug > 2.1.0#1939
Merged
antonpirker merged 2 commits intogetsentry:masterfrom Mar 3, 2023
Merged
fix(integration): fix FlaskIntegration for Werkzeug > 2.1.0#1939antonpirker merged 2 commits intogetsentry:masterfrom
antonpirker merged 2 commits intogetsentry:masterfrom
Conversation
|
Fixes: #1936 |
antonpirker
reviewed
Mar 3, 2023
Contributor
antonpirker
left a comment
There was a problem hiding this comment.
So in old Werkzeug doing .get_json() never resulted in an error and now an error will be thrown unless you add .get_json(silent=True) which then makes get_json behave like in the old Werkzeug? Is this correct?
Contributor
Author
@antonpirker Yes, exactly correct! And this is backwards compatible with old versions of Werkzeug as well, |
antonpirker
approved these changes
Mar 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explained in this bug report, recent versions of werkzeug introduced the behaviour to
get_jsonwhere it will throw an error when content_type isn't set.