Handle no release when uploading profiles#1548
Merged
szokeasaurusrex merged 3 commits intomasterfrom Aug 8, 2022
Merged
Conversation
sl0thentr0py
requested changes
Aug 8, 2022
sentry_sdk/client.py
Outdated
| if "profile" in event_opt: | ||
| event_opt["profile"]["transaction_id"] = event_opt["event_id"] | ||
| event_opt["profile"]["version_name"] = event_opt["release"] | ||
| try: |
Member
There was a problem hiding this comment.
Suggested change
| try: | |
| event_opt["profile"]["version_name"] = event_opt.get("release", "") |
sl0thentr0py
approved these changes
Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed that an error occurs when a profile is being uploaded and there is no release set (the error can only occur when profiling is enabled). This PR stops the error from occurring.