Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: getsentry/sentry-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 60ef594
Choose a base ref
...
head repository: getsentry/sentry-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: aba1db6
Choose a head ref
  • 4 commits
  • 8 files changed
  • 3 contributors

Commits on Aug 31, 2022

  1. Merge branch 'release/1.9.6'

    getsentry-bot committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    8853cfc View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Let SentryAsgiMiddleware work with Starlette and FastAPI integrations (

    …#1594)
    
    People where complaining (rightly so) that just raising an error when SentryAsgiMiddleware and Starlette/Fastapi is used is not a nice thing to do.
    
    So we tried again to make this work together. To not break our users code.
    The plan was to make SentryASGIMiddleware no-op when there is already one there. Turns out this works already on Starlette but on FastAPI it broke. (This was because of how FastAPI deals with middlewares)
    
    We debugged the whole thing and it turns out that we where patching our own SentryAsgiMiddleware (like the FastAPI internal ones) to create spans when they are executed. This and the fact that we use __slots__ extensively made the integration break.
    
    We found out, that if we are not patching our own middleware this fixes the problem when initializing the middleware twice (once by our users and once by our auto-enabled FastAPI integration).
    
    Fixes #1592
    antonpirker authored Sep 1, 2022
    Configuration menu
    Copy the full SHA
    d0b70df View commit details
    Browse the repository at this point in the history
  2. release: 1.9.7

    getsentry-bot committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    0100ab8 View commit details
    Browse the repository at this point in the history
  3. Updated changelog

    antonpirker committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    aba1db6 View commit details
    Browse the repository at this point in the history
Loading