Skip to content

ci: Collect code coverage via llvm#318

Merged
Swatinem merged 9 commits intomasterfrom
ci/llvm-cov
Jun 25, 2020
Merged

ci: Collect code coverage via llvm#318
Swatinem merged 9 commits intomasterfrom
ci/llvm-cov

Conversation

@Swatinem
Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 25, 2020

Codecov Report

Merging #318 into master will decrease coverage by 7.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
- Coverage   92.51%   85.18%   -7.33%     
==========================================
  Files          37       49      +12     
  Lines        2097     3963    +1866     
==========================================
+ Hits         1940     3376    +1436     
- Misses        157      587     +430     
Impacted Files Coverage Δ
src/sentry_path.h 40.00% <0.00%> (-60.00%) ⬇️
src/sentry_logger.c 70.37% <0.00%> (-29.63%) ⬇️
src/sentry_random.c 73.07% <0.00%> (-26.93%) ⬇️
src/sentry_string.c 81.42% <0.00%> (-13.81%) ⬇️
src/transports/sentry_disk_transport.c 87.50% <0.00%> (-12.50%) ⬇️
src/transports/sentry_function_transport.c 81.25% <0.00%> (-10.42%) ⬇️
src/sentry_database.c 80.14% <0.00%> (-10.39%) ⬇️
src/sentry_slice.h 90.00% <0.00%> (-10.00%) ⬇️
src/path/sentry_path.c 90.47% <0.00%> (-9.53%) ⬇️
src/path/sentry_path_unix.c 82.18% <0.00%> (-8.73%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0e62ac...aed90bf. Read the comment docs.

@Swatinem Swatinem marked this pull request as ready for review June 25, 2020 12:19
@Swatinem Swatinem requested a review from a team June 25, 2020 12:19
@Swatinem Swatinem merged commit 3a3d10b into master Jun 25, 2020
@Swatinem Swatinem deleted the ci/llvm-cov branch June 25, 2020 12:33
Copy link
Copy Markdown
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entirely informational, but the pathlib module in the python stdlib is fairly nice for the kind of manipulations you're doing as well.

Swatinem added a commit that referenced this pull request Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants