fix(test): replace copytree with symlink in the Windows UTF8_TEST#1633
Merged
Conversation
Collaborator
Author
|
The Windows UTF-8 path test is again in the same ballpark as the other Windows tests (without sccache). This means well below 30 minutes (vs. previously often easily 40 minutes, unnecessarily extending the entire CI runtime). |
BernhardMarconato
pushed a commit
to elgatosf/sentry-native
that referenced
this pull request
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As recently discussed, copying the build-dir can be replaced with a far less wasteful symlinking approach. Also moved it into its own tmp-dir, which eliminates that recursive positioning.
#skip-changelog