test: de-dupe and fix flaky logs/metrics crash tests#1567
Merged
Conversation
Consolidate duplicate inproc/breakpad log crash tests via parametrize. Switch all crash tests to oneshot requests and httpserver.wait() to avoid flakiness. Native backend tests are separate since the daemon sends envelopes directly, and parametrize rerun vs. no-rerun to verify a second daemon doesn't conflict. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
supervacuus
approved these changes
Mar 10, 2026
BernhardMarconato
pushed a commit
to elgatosf/sentry-native
that referenced
this pull request
Apr 21, 2026
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate duplicate inproc/breakpad log crash tests via parametrize. Switch all logs/metrics_on_crash tests to oneshot requests and use httpserver.wait() to avoid flakiness. Native backend tests are separate since the daemon sends envelopes directly, and parametrize rerun vs. no-rerun to verify a second daemon doesn't conflict.
Close: #1560