Skip to content

chore(build): avoid unnecessary venv rebuild on every make invocation#1553

Merged
jpnurmi merged 1 commit into
masterfrom
jpnurmi/chore/make-venv-stamp
Mar 11, 2026
Merged

chore(build): avoid unnecessary venv rebuild on every make invocation#1553
jpnurmi merged 1 commit into
masterfrom
jpnurmi/chore/make-venv-stamp

Conversation

@jpnurmi

@jpnurmi jpnurmi commented Mar 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Problem: make style, make format, etc. re-ran pip install on every invocation because .venv/bin/python is a symlink — make resolves it and sees the system Python's mtime, which is older than Makefile, so the target is perpetually out-of-date.

Fix: use a .venv/.stamp file as the make target instead.

Before:

$ git clean -xdf
[...]
$ make style
python3 -m venv .venv
.venv/bin/pip install --upgrade --requirement tests/requirements.txt
[~180 lines...]
Installing collected packages: sortedcontainers, pyperclip, publicsuffix2, passlib, clang-format, Brotli, zstandard, wcwidth, urllib3, typing-extensions, tornado, ruamel.yaml, pyparsing, pylsqpack, pycparser, pyasn1, psutil, protobuf, pluggy, platformdirs, pathspec, packaging, mypy-extensions, msgpack, mitmproxy-rs, MarkupSafe, kaitaistruct, itsdangerous, iniconfig, idna, hyperframe, hpack, h11, flaky, execnet, click, charset_normalizer, certifi, blinker, attrs, asgiref, wsproto, Werkzeug, urwid, requests, pytest, pyasn1-modules, ldap3, Jinja2, h2, cffi, black, pytest-xdist, pytest-httpserver, flask, cryptography, service-identity, pyOpenSSL, aioquic, mitmproxy
Successfully installed Brotli-1.1.0 Jinja2-3.1.6 MarkupSafe-3.0.3 Werkzeug-3.1.6 aioquic-1.2.0 asgiref-3.8.1 attrs-25.4.0 black-24.3.0 blinker-1.9.0 certifi-2026.2.25 cffi-2.0.0 charset_normalizer-3.4.5 clang-format-20.1.5 click-8.3.1 cryptography-43.0.3 execnet-2.1.2 flaky-3.8.1 flask-3.0.3 h11-0.14.0 h2-4.1.0 hpack-4.1.0 hyperframe-6.0.1 idna-3.11 iniconfig-2.3.0 itsdangerous-2.2.0 kaitaistruct-0.10 ldap3-2.9.1 mitmproxy-11.0.0 mitmproxy-rs-0.9.3 msgpack-1.0.8 mypy-extensions-1.1.0 packaging-26.0 passlib-1.7.4 pathspec-1.0.4 platformdirs-4.9.4 pluggy-1.6.0 protobuf-5.28.2 psutil-7.1.1 publicsuffix2-2.20191221 pyOpenSSL-24.2.1 pyasn1-0.6.2 pyasn1-modules-0.4.2 pycparser-3.0 pylsqpack-0.3.23 pyparsing-3.1.4 pyperclip-1.9.0 pytest-8.1.1 pytest-httpserver-1.0.10 pytest-xdist-3.5.0 requests-2.32.4 ruamel.yaml-0.18.6 service-identity-24.2.0 sortedcontainers-2.4.0 tornado-6.4.1 typing-extensions-4.15.0 urllib3-2.6.3 urwid-2.6.15 wcwidth-0.6.0 wsproto-1.2.0 zstandard-0.23.0
All done! ✨ 🍰 ✨
27 files would be left unchanged.
$ make style
python3 -m venv .venv
.venv/bin/pip install --upgrade --requirement tests/requirements.txt
[~180 lines...]
Installing collected packages: sortedcontainers, pyperclip, publicsuffix2, passlib, clang-format, Brotli, zstandard, wcwidth, urllib3, typing-extensions, tornado, ruamel.yaml, pyparsing, pylsqpack, pycparser, pyasn1, psutil, protobuf, pluggy, platformdirs, pathspec, packaging, mypy-extensions, msgpack, mitmproxy-rs, MarkupSafe, kaitaistruct, itsdangerous, iniconfig, idna, hyperframe, hpack, h11, flaky, execnet, click, charset_normalizer, certifi, blinker, attrs, asgiref, wsproto, Werkzeug, urwid, requests, pytest, pyasn1-modules, ldap3, Jinja2, h2, cffi, black, pytest-xdist, pytest-httpserver, flask, cryptography, service-identity, pyOpenSSL, aioquic, mitmproxy
Successfully installed Brotli-1.1.0 Jinja2-3.1.6 MarkupSafe-3.0.3 Werkzeug-3.1.6 aioquic-1.2.0 asgiref-3.8.1 attrs-25.4.0 black-24.3.0 blinker-1.9.0 certifi-2026.2.25 cffi-2.0.0 charset_normalizer-3.4.5 clang-format-20.1.5 click-8.3.1 cryptography-43.0.3 execnet-2.1.2 flaky-3.8.1 flask-3.0.3 h11-0.14.0 h2-4.1.0 hpack-4.1.0 hyperframe-6.0.1 idna-3.11 iniconfig-2.3.0 itsdangerous-2.2.0 kaitaistruct-0.10 ldap3-2.9.1 mitmproxy-11.0.0 mitmproxy-rs-0.9.3 msgpack-1.0.8 mypy-extensions-1.1.0 packaging-26.0 passlib-1.7.4 pathspec-1.0.4 platformdirs-4.9.4 pluggy-1.6.0 protobuf-5.28.2 psutil-7.1.1 publicsuffix2-2.20191221 pyOpenSSL-24.2.1 pyasn1-0.6.2 pyasn1-modules-0.4.2 pycparser-3.0 pylsqpack-0.3.23 pyparsing-3.1.4 pyperclip-1.9.0 pytest-8.1.1 pytest-httpserver-1.0.10 pytest-xdist-3.5.0 requests-2.32.4 ruamel.yaml-0.18.6 service-identity-24.2.0 sortedcontainers-2.4.0 tornado-6.4.1 typing-extensions-4.15.0 urllib3-2.6.3 urwid-2.6.15 wcwidth-0.6.0 wsproto-1.2.0 zstandard-0.23.0
All done! ✨ 🍰 ✨
27 files would be left unchanged.

After:

$ git clean -xdf
[...]
$ make style
python3 -m venv .venv
.venv/bin/pip install --upgrade --requirement tests/requirements.txt
[~180 lines...]
Installing collected packages: sortedcontainers, pyperclip, publicsuffix2, passlib, clang-format, Brotli, zstandard, wcwidth, urllib3, typing-extensions, tornado, ruamel.yaml, pyparsing, pylsqpack, pycparser, pyasn1, psutil, protobuf, pluggy, platformdirs, pathspec, packaging, mypy-extensions, msgpack, mitmproxy-rs, MarkupSafe, kaitaistruct, itsdangerous, iniconfig, idna, hyperframe, hpack, h11, flaky, execnet, click, charset_normalizer, certifi, blinker, attrs, asgiref, wsproto, Werkzeug, urwid, requests, pytest, pyasn1-modules, ldap3, Jinja2, h2, cffi, black, pytest-xdist, pytest-httpserver, flask, cryptography, service-identity, pyOpenSSL, aioquic, mitmproxy
Successfully installed Brotli-1.1.0 Jinja2-3.1.6 MarkupSafe-3.0.3 Werkzeug-3.1.6 aioquic-1.2.0 asgiref-3.8.1 attrs-25.4.0 black-24.3.0 blinker-1.9.0 certifi-2026.2.25 cffi-2.0.0 charset_normalizer-3.4.5 clang-format-20.1.5 click-8.3.1 cryptography-43.0.3 execnet-2.1.2 flaky-3.8.1 flask-3.0.3 h11-0.14.0 h2-4.1.0 hpack-4.1.0 hyperframe-6.0.1 idna-3.11 iniconfig-2.3.0 itsdangerous-2.2.0 kaitaistruct-0.10 ldap3-2.9.1 mitmproxy-11.0.0 mitmproxy-rs-0.9.3 msgpack-1.0.8 mypy-extensions-1.1.0 packaging-26.0 passlib-1.7.4 pathspec-1.0.4 platformdirs-4.9.4 pluggy-1.6.0 protobuf-5.28.2 psutil-7.1.1 publicsuffix2-2.20191221 pyOpenSSL-24.2.1 pyasn1-0.6.2 pyasn1-modules-0.4.2 pycparser-3.0 pylsqpack-0.3.23 pyparsing-3.1.4 pyperclip-1.9.0 pytest-8.1.1 pytest-httpserver-1.0.10 pytest-xdist-3.5.0 requests-2.32.4 ruamel.yaml-0.18.6 service-identity-24.2.0 sortedcontainers-2.4.0 tornado-6.4.1 typing-extensions-4.15.0 urllib3-2.6.3 urwid-2.6.15 wcwidth-0.6.0 wsproto-1.2.0 zstandard-0.23.0
All done! ✨ 🍰 ✨
27 files would be left unchanged.
$ make style
All done! ✨ 🍰 ✨
27 files would be left unchanged.

@jpnurmi @claude
chore(build): avoid unnecessary venv rebuild on every make invocation
09749f8 
.venv/bin/python is a symlink whose resolved mtime never updates,
causing make to always consider it out-of-date. Use a stamp file instead.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jpnurmi jpnurmi requested a review from supervacuus March 11, 2026 13:03
supervacuus
supervacuus approved these changes Mar 11, 2026
View reviewed changes

@supervacuus supervacuus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@jpnurmi jpnurmi merged commit 9a8aa27 into master Mar 11, 2026
81 of 82 checks passed
@jpnurmi jpnurmi deleted the jpnurmi/chore/make-venv-stamp branch March 11, 2026 14:36
BernhardMarconato pushed a commit to elgatosf/sentry-native that referenced this pull request Apr 21, 2026
@jpnurmi @claude
chore(build): avoid unnecessary venv rebuild on every make invocation (…
16a94f5 
…getsentry#1553)

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@supervacuus supervacuus supervacuus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpnurmi @supervacuus