chore: Skip getenv_double test on PlayStation#1547
Merged
Conversation
jpnurmi
reviewed
Mar 2, 2026
Co-authored-by: J-P Nurmi <jpnurmi@gmail.com>
jpnurmi
approved these changes
Mar 2, 2026
BernhardMarconato
pushed a commit
to elgatosf/sentry-native
that referenced
this pull request
Apr 21, 2026
* chore: fix missing PS5 function declerations * Revert function decl * Disable getenv_double test on PS5 * Update tests/unit/test_utils.c Co-authored-by: J-P Nurmi <jpnurmi@gmail.com> --------- Co-authored-by: J-P Nurmi <jpnurmi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PlayStation doesn't provide
setenv/unsetenvin its C library, causing linker errors when building the unit tests. Thegetenv_doubletest relies on these POSIX functions to set up environment variables, so it cannot run meaningfully on this platform.This PR wraps the test body with
#if !defined(SENTRY_PLATFORM_PS)to skip it on PlayStation while keeping the test active on all other platforms.#skip-changelog