add NDK testing setup #1180
Merged
add NDK testing setup #1180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Member
Author
|
To avoid overlapping efforts with #962 , we'll limit this PR to only set up NDK tests without running them in CI. |
Collaborator
171febc
into
joshua/feat/sync_android_tracessamplerate
25 checks passed
JoshuaMoelans
added a commit
that referenced
this pull request
Mar 25, 2025
* Add dependencies to allow running unit tests as well as instrumented android tests * add ndk test into CI * moved NDK check+test into `test` job * add conditional check for ANDROID_API in NDK test/check jobs * trying to fix CI * trying to fix CI 2 * Add Java/Gradle setup steps * Apply checks to NDK lib only * Apply code formatting * run tests on reactivecircus emulator * remove KVM enable step * update CI (remove NDK test) --------- Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io>
JoshuaMoelans
added a commit
that referenced
this pull request
Mar 28, 2025
* upgrade gradle * add tracesSampleRate sync in NDK * add tracing to NDK example * update CHANGELOG.md * add NDK testing setup (#1180) * Add dependencies to allow running unit tests as well as instrumented android tests * add ndk test into CI * moved NDK check+test into `test` job * add conditional check for ANDROID_API in NDK test/check jobs * trying to fix CI * trying to fix CI 2 * Add Java/Gradle setup steps * Apply checks to NDK lib only * Apply code formatting * run tests on reactivecircus emulator * remove KVM enable step * update CI (remove NDK test) --------- Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io> * make tracesSampleRate a get/set instead of constructor parameter * add check for transaction type in test * change log levels * update CHANGELOG.md * apply suggestions from review * add messageCaught function * remove CI testing artifact * Apply suggestions from code review Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com> * suggestion from code review * move NdkTestHelper * remove unnecessary crash() function * cleanup tests --------- Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io> Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
sidequest to be merged into #1176