feat: Only do automatic commit association for Vercel production environments#711
Merged
feat: Only do automatic commit association for Vercel production environments#711
Conversation
Lms24
approved these changes
Mar 31, 2025
| // We only want to set commits for the production env because Sentry becomes extremely noisy (eg on slack) for | ||
| // preview environments because the previous commit is always the "stem" commit of the preview/PR causing Sentry | ||
| // to notify you for other people creating PRs. | ||
| process.env["VERCEL_TARGET_ENV"] === "production" |
Member
There was a problem hiding this comment.
Is there a way that users can overwrite this env variable for their production build? I guess though even if it's possible, it's probably an edge case we can ignore live with (?)
Author
There was a problem hiding this comment.
Had the same thought: I think we just don't care. I don't think many people would change their prod env name at all.
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Apr 5, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 3.2.4 | 3.3.1 | ## [v3.3.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#331) - fix(webpack5): All `esm` files must have `.mjs` postfix ([#721](getsentry/sentry-javascript-bundler-plugins#721)) ## [v3.3.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#330) - feat(webpack): Add `@sentry/webpack-plugin/webpack5` export for webpack 5.1+ and compatible environments ([#715](getsentry/sentry-javascript-bundler-plugins#715)) - feat: Only do automatic commit association for Vercel production environments ([#711](getsentry/sentry-javascript-bundler-plugins#711))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Apr 5, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 3.2.4 | 3.3.1 | ## [v3.3.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#331) - fix(webpack5): All `esm` files must have `.mjs` postfix ([#721](getsentry/sentry-javascript-bundler-plugins#721)) ## [v3.3.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#330) - feat(webpack): Add `@sentry/webpack-plugin/webpack5` export for webpack 5.1+ and compatible environments ([#715](getsentry/sentry-javascript-bundler-plugins#715)) - feat: Only do automatic commit association for Vercel production environments ([#711](getsentry/sentry-javascript-bundler-plugins#711))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just noticed this is extremely spammy when you have your git email connected with Sentry.