Conversation
Lms24
commented
Oct 20, 2022
| owner: getsentry | ||
| repo: bundler-plugins | ||
| changelogPolicy: simple | ||
| preReleaseCommand: bash scripts/craft-pre-release.sh |
Member
Author
There was a problem hiding this comment.
Technically, this is an optional property as by default, Craft will look for a script called scripts/bump-version.sh. However, I think having this written here explicitly is better as it makes it clear what this script is doing in the repo and where it is needed.
25c47bf to
a005d1b
Compare
9d3170e to
f915d83
Compare
Member
Author
|
I'd like to merge this in to get the "Prepare Release" workflow to work properly. There might still be problems with overall craft/GHA config but we kinda need the prepare release WF to show up first s.t. we can start it and provide the inputs it needs. |
lforst
approved these changes
Oct 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a few files to set up Craft and our release process.
Draft for testing purposes