ref(node): Refactor node integrations to functional syntax#9959
Merged
ref(node): Refactor node integrations to functional syntax#9959
Conversation
mydea
commented
Dec 21, 2023
packages/node/src/index.ts
Outdated
| ...CoreIntegrations, | ||
| ...NodeIntegrations, | ||
| ...(NodeIntegrations as { | ||
| Console: Integration; |
Member
Author
There was a problem hiding this comment.
TS complains about this otherwise, somehow 😬 with TS4023: Exported Variable <x> has or is using name <y> from external module but cannot be named. No idea, but I think this is fine for now...
AbhiPrasad
approved these changes
Dec 21, 2023
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Feels like converting from react class components to functional components.
2643b46 to
5765909
Compare
Contributor
size-limit report 📦
|
3a6e9ae to
2c2b356
Compare
b58856e to
9c16a78
Compare
9c16a78 to
9d70bd5
Compare
anonrig
pushed a commit
that referenced
this pull request
Jan 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting there...